Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@peterflynn
Copy link
Member

Fix bug #330 (Calling FileIndexManager.getFileInfoList() fails if another such call is in progress):

Keep track of existing index-sync promise so we can just wait on it instead of failing. Includes unit test.

…r such

call is already in progress fails) - keep track of existing index-sync
promise so we can just wait on it instead of failing.
@gruehle
Copy link
Member

gruehle commented Mar 7, 2013

What happens if you have a pending request that is different than the new request? For example:

var promise1 = FileIndexManager.getFileInfoList("all");
var promise2 = FileIndexManager.getFileInfoList("css");

@gruehle
Copy link
Member

gruehle commented Mar 7, 2013

I'll answer my own question - it works :-)

@gruehle
Copy link
Member

gruehle commented Mar 7, 2013

Thanks for fixing this! I ran into this problem again the other day and was going to fix it, but you beat me to it. Merging.

gruehle added a commit that referenced this pull request Mar 7, 2013
Fix bug #330 (Calling FileIndexManager.getFileInfoList() fails if another such call in progress)
@gruehle gruehle merged commit 90aae26 into master Mar 7, 2013
@gruehle gruehle deleted the pflynn/fileindexmanager-reentrancy branch March 7, 2013 21:17
peterflynn added a commit that referenced this pull request Apr 12, 2013
* DocumentManager: use CollectionUtils.forEach() in notifyPathNameChanged()
(removing early-exit optimization that's probably unneeded; can reintroduce
when CollectionUtils.some() lands)
* Move filename->language mapping tests from Editor-test to LanguageManager-test
* Add another #330 testcase as suggested by Glenn in #3064
* Add StringMatch testcases as suggested by Kevin in #3417
* SpecRunnerUtils: use waitsForDone() more
* CSSUtils-test: remove unused vars
* Dialogs: tiny docs improvement
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants