Fix About Dialog Contributors (Issue 3012 from Pull 2934)

[TuckerWhitehouse]

This is a fix for #3012 in response to #2934 reworking the _getContributorsInformation function to return the $.getJSON call directly, as well as add a "graceful" fail message as suggested by @njx.

Hoping this could get merged into spring 21 rather than being pushed to 22.

[TomMalbran]

I think you should just remove this function and replace _getContributorsInformation() and inside _handleAboutDialog() just call $.getJSON(brackets.config.contributors_url) as @njx proposed.

[TomMalbran]

Great, but you still need to replace the text in .html with Strings.ABOUT_TEXT_LINE6 so that it can be seen in other languages too.

[njx]

Cool, thanks for jumping on this @TuckerWhitehouse and @TomMalbran. Tom--if this looks good to you, feel free to merge now--we won't be closing the codebase for the sprint until some other stuff is merged anyway.

[TomMalbran]

@njx Will do. I just have one last comment after checking how it looks when the request fails.

[TomMalbran]

Thanks, awesome. I'll merge it now.

For the next time, you might want to consider using branches instead of pulling directly from your master, it helps a lot when the request takes longer to be merged, since you can just leave it there and work on other stuff on other branches or in the master.

[njx]

Good catch on the font. (We should probably clean up the CSS at some point so we don't have to repeat that on every child of the parent.)

[TomMalbran]

That should be easy enough to do in this case. But we might need to check every other template too.