Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix Issue #2877: Debug menu shortcuts are enabled even when Debug menu is hidden #2888

Merged
merged 1 commit into from
Feb 21, 2013
Merged

Fix Issue #2877: Debug menu shortcuts are enabled even when Debug menu is hidden #2888

merged 1 commit into from
Feb 21, 2013

Conversation

TomMalbran
Copy link
Contributor

This fixes #2877 by disabling the "Refresh Brackets" and "Show Developer Tools" commands after they are created using the brackets.config.show_debug_menu value.

@ghost ghost assigned jasonsanjose Feb 19, 2013
@peterflynn
Copy link
Member

For future-proofing, should we do the same thing for all the other debug-menu commands, in case we ever add shortcuts to any of them?

@jasonsanjose
Copy link
Member

@peterflynn I have an alternative suggestion as #2902. Would this fix from @TomMalbran as-is be appropriate if the long term goals is to externalize the debug commands?

@peterflynn
Copy link
Member

@jasonsanjose I'd imagine if we did #2902 we could eliminate the whole show_debug_menu config flag, along with the code in this patch. And it would definitely eliminate my concern, since this bug couldn't easily regress with other Debug menu items. Seems worth merging this patch in the meantime, though.

jasonsanjose added a commit that referenced this pull request Feb 21, 2013
Fix Issue #2877: Debug menu shortcuts are enabled even when Debug menu is hidden
@jasonsanjose jasonsanjose merged commit 4c42b81 into adobe:master Feb 21, 2013
@TomMalbran TomMalbran deleted the tom/fix-issue-2877 branch February 21, 2013 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug menu shortcuts are enabled even when Debug menu is hidden
3 participants