This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Adds NodeConnection class to connect to node server, as well as unit tests #2880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
src/debug/NodeDebugUtils.js
Outdated
Member
There was a problem hiding this comment.
Might be nice to have an option to turn off node logging.
Contributor
Author
There was a problem hiding this comment.
I agree. Added a TODO.
Member
|
Initial review complete. |
Contributor
Author
|
@gruehle thanks for the review! I've addressed all your concerns. All tests pass on mac and win with master merged in to this branch. Master merges cleanly. And Travis fixed itself! |
Member
|
Looks good! Merging. |
gruehle
added a commit
that referenced
this pull request
Feb 21, 2013
Adds NodeConnection class to connect to node server, as well as unit tests
This was referenced Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates the extension joelrbrandt/brackets-node-client into core