This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
CodeHintList shouldn't get keyboard events if closed #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e resolved and the hint list is actually open
ghost
assigned 
| @@ -447,7 +447,7 @@ define(function (require, exports, module) { | |||
| } | |||
| // Begin a new explicit session | |||
| _beginSession(editor); | |||
| } else if (_inSession(editor)) { | |||
| } else if (_inSession(editor) && hintList.isOpen()) { | |||
| // Pass event to the hint list, if it's open | |||
| hintList.handleKeyEvent(event); | |||
| } | |||
There was a problem hiding this comment.
Excellent timing! I've been reviewing the CSS code hinting pull request by @zoufahl and this fix needs one more change to set lastChar:
} else {
lastChar = String.fromCharCode(event.keyCode);
}
Note that this uses event.keyCode (not event.charCode).
There was a problem hiding this comment.
What's the problem that the extra assignment is for? Should there be a separate issue? And might there be a problem with passing a keyCode where a charCode is expected?
There was a problem hiding this comment.
You're right -- this is not really related to the bug you're fixing. We'll fix it in the other branch.
FYI, I used keyCode because charCode is 0 for Tab and Enter.
|
Done with review. |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Jan 14, 2013
…gfix CodeHintList shouldn't get keyboard events if closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a code hint provider initially (upon hinting session creation) returns deferred hints, the CodeHintList is not opened until those deferred hints have resolved to an actual list of hints. Until this resolution, the CodeHintManager should not forward keyboard events to the CodeHintList, which captures some navigation events to handle scrolling and paging through the list. This tiny pull request just ensures that the CodeHintList is actually open, and not just in a hinting session, before the CodeHintManager passes it any keyboard events.