This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix for issue #2227 #2446
Merged
Fix for issue #2227 #2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
Contributor
|
@RaymondLim you're absolutely correct. I was looking at the regex in isolation and thought I saw matches that should work but wouldn't. I just tested the cases above in proper context and all but one worked fine. The only one that doesn't work is if there are multiple spaces in front of one of the values, which seems like a bit of a degenerate case, albeit one that actually appears on the MDN page for the color data type. @chtennek sorry for holding this up, and thanks for the fix (with tests and all). I'll merge it now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color Picker doesn't open if alpha value in rgba() starts with .