Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@jackbillstrom
Copy link
Contributor

Swedish is now working, UTF-8, no problem what so ever! Sorry for a new pull reguest!

@jackbillstrom
Copy link
Contributor Author

But it shows that the indentation is messed up, but inside the file, it isn't!
https://github.com/jackbillstrom/brackets/blob/9025ba7684dcec0cd4dc83153061cf9aa9821e61/src/nls/strings.js

@ghost ghost assigned pthiess Dec 12, 2012
@TomMalbran
Copy link
Contributor

Change the tabs to spaces and it will fix the indentation. Brackets code uses 4 spaces indentations instead of tabs.

@pthiess
Copy link
Contributor

pthiess commented Dec 14, 2012

HEY JACK, THANKS A TON FOR YOUR EFFORT!

The changes can't be merged as they are - https://github.com/adobe/brackets/blob/master/src/nls/strings.js may have changed - make sure you merge from adobe/brackets master.
Please consider to contribute a translation of the Getting Started page - this is not mandatory and can be done at a later point. However you may want to look at how the Spanish translation was integrated and you will need to add the reference in https://github.com/adobe/brackets/blob/master/src/nls/urls.js.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use spaces, not tabs

@pthiess pthiess mentioned this pull request Dec 14, 2012
@ghost ghost assigned jasonsanjose Jan 4, 2013
@pthiess
Copy link
Contributor

pthiess commented Jan 4, 2013

@jasonsanjose: We haven't heard back, should we just try to merge in the changes?
THX,
Peter

@jasonsanjose jasonsanjose mentioned this pull request Jan 4, 2013
@jasonsanjose
Copy link
Member

Closing, see #2477

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants