Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@shumpei
Copy link

@shumpei shumpei commented Oct 24, 2012

Currently, target version is sprint 15.
Almost all messages are translated to Japanese.

Currently, target version is sprint 15.
@pthiess
Copy link
Contributor

pthiess commented Oct 24, 2012

Awesome :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this file from this pull request since you're not submitting a translated getting started project.

If you plan on doing this in the future, you would update the GETTING_STARTED path below to a relative path under the /samples folder and also update src/nls/urls.js to add ja to the list of languages.

@ghost ghost assigned jasonsanjose Oct 24, 2012
@jasonsanjose
Copy link
Member

Normally I've used google translate to help me sanity check community translations. I think I'll need some extra help on this one though. I'll post to the google group to see if anyone else can help.

@shumpei
Copy link
Author

shumpei commented Oct 25, 2012

I'm sorry for containing unnecessary file (urls.js).
I deleted the file from my branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a space after {APP_NAME} just like you have in the above line? Not only this instance, but you have others with {APP_NAME} or {APP_TITLE} without a space. Can you fix all these instances for consistency?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion.
Done!

2012�$BG/�(B10�$B7n�(B25�$BF|�(B 11:33 Raymond Lim notifications@github.com:

In src/nls/ja/strings.js:

  • "ERROR_OPENING_FILE" : "�$B%U%!%$%k$r3+$/:]$K%(%i!<$,H/@8$7$^$7$?!#�(B{0}. {1}",
  • "ERROR_RELOADING_FILE_TITLE" : "�$B%U%!%$%k$r:FFI9~$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#�(B",
  • "ERROR_RELOADING_FILE" : "�$B%U%!%$%k$r:FFI9~$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#�(B{0}. {1}",
  • "ERROR_SAVING_FILE_TITLE" : "�$B%U%!%$%k$rJ]B8$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#�(B",
  • "ERROR_SAVING_FILE" : "�$B%U%!%$%k$rJ]B8$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#�(B{0}. {1}",
  • "ERROR_RENAMING_FILE_TITLE" : "�$B%U%!%$%k$NL>A0$rJQ99$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#�(B",
  • "ERROR_RENAMING_FILE" : "�$B%U%!%$%k$NL>A0$rJQ99$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#�(B{0}. {1}",
  • "INVALID_FILENAME_TITLE" : "�$B%U%!%$%kL>$,IT@5$G$9!#�(B",
  • "INVALID_FILENAME_MESSAGE" : "�$B%U%!%$%kL>$K$O!"<!$NJ8;z$r4^$a$k$3$H$O$G$-$^$;$s�(B: /?*:;{}<>|",
  • "FILE_ALREADY_EXISTS" : "�$B%U%!%$%k�(B {0} �$B$O4{$KB8:_$7$F$$$^$9!#�(B",
  • "ERROR_CREATING_FILE_TITLE" : "�$B%U%!%$%k$r:n@.$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#�(B",
  • "ERROR_CREATING_FILE" : "�$B%U%!%$%k$r:n@.$9$k:]$K%(%i!<$,H/@8$7$^$7$?!#�(B{0}. {1}",
  • // Application error strings
  • "ERROR_IN_BROWSER_TITLE" : "{APP_NAME} �$B$O!"$^$@%V%i%&%6>e$G<B9T$5$l$F$$$^$;$s!*�(B",
  • "ERROR_IN_BROWSER" : "{APP_NAME}�$B$O�(BHTML�$B$G9=C[$5$l$F$$$^$9$,!"%G%9%/%H%C%W%"%W%j$H$7$F<B9T$9$k$3$H$G!"%m!<%+%k%U%!%$%k$rJT=8$9$k$3$H$,$G$-$^$9!#�(B{APP_NAME}�$B$r<B9T$9$k$?$a$K!"�(Bgithub.com/adobe/brackets-shell �$B%j%]%8%H%j$r;HMQ$7$F$/$@$5$$!#�(B",

Can you add a space after {APP_NAME} just like you have in the above line?
Not only this instance, but you have others with {APP_NAME} or {APP_TITLE}
without a space. Can you fix all these instances for consistency?

�$B!=�(B
Reply to this email directly or view it on GitHubhttps://github.com//pull/1929/files#r1936766.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original English string has a space at the end and a number is appended to this string. So do you need a space also? just checking...

@shumpei
Copy link
Author

shumpei commented Oct 25, 2012

Thank you again for pointing out probrem!
I fixed it, so the result message of search function may be natural for almost of Japanese.

@shumpei shumpei closed this Oct 25, 2012
@shumpei shumpei reopened this Oct 25, 2012
@shumpei
Copy link
Author

shumpei commented Oct 25, 2012

Sorry, I closed this issue in error... Reopened.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor nit. If I remember it correctly, Japanese UI strings always have a space before : for most labels in UI. If so you need to have one for this string.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of Japanese don't care about the space.

Example

Additionally, most of Japanese don't care whether the colon is single byte (:) or multi byte (), too!

If you feel there is no problem, I will do nothing. What do you think of this?

Thank you for checking details!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's fine. I remembered Dreamweaver has space before the colon in all Japanese labels in UI, but we can go without it for Brackets. Thanks anyway.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see.
If Dreamweaver is implemented so, I must follow that style (because this is ADOBE brackets!)
I modified.
Please see.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to translate this too. Currently, if you try Replace command you will see 置換 {TextToSearch} With {TextToReplace}. Or if you don't think we need this, you can just have an empty string here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I translated 'With' to '置換後の文字列'.
shumpei@1b3f0ca

I'm sorry for my mistake and thank you for your robust review!

@RaymondLim
Copy link
Contributor

Thanks for your hard work! Merging now.

RaymondLim added a commit that referenced this pull request Oct 26, 2012
@RaymondLim RaymondLim merged commit 7cc28ce into adobe:master Oct 26, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants