Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Added button to remove projects from the recent project dropdown. #1757

Merged
merged 3 commits into from
Oct 17, 2012

Conversation

adrocknaphobia
Copy link
Contributor

No description provided.

@ghost ghost assigned redmunds Oct 3, 2012
<use xlink:href="#cross" x="15" fill="#9f9f9f"/>
<circle cx="37" cy="8" r="3" filter="url(#blur)" opacity=".5"/>
<circle fill="#868686" cx="37" cy="7" r="3"/>
</svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already an X icon used for the Working Set list. I think you should be able to re-use that one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, it's probably better to use your own icon so there's no dependency.

@redmunds
Copy link
Contributor

redmunds commented Oct 3, 2012

Done with initial review. Very cool, but needs some code cleanup work.

@adrocknaphobia
Copy link
Contributor Author

Well... I cleaned up the code, but not sure I pushed it correctly. Am I supposed to have a second commit (e0f2674)?

@redmunds
Copy link
Contributor

@adrocknaphobia The second commit is ok. It is due to you merging in all of the changes to master which have occurred since you first submitted this pull request. If you switch to the "Files Changed" tab, you can see that only your changes are listed.

Looks good. Merging.

redmunds added a commit that referenced this pull request Oct 17, 2012
Added button to remove projects from the recent project dropdown.
@redmunds redmunds merged commit 772fec1 into master Oct 17, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants