This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Path is converted to windows style when opening with external editor in win #15096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niteskum
changed the title
g-217
reviewed
Mar 19, 2020
| @@ -48,9 +48,16 @@ define(function (require, exports, module) { | |||
|
|
|||
| var extensionToExtApplicationMap = {}; | |||
|
|
|||
| function convertUnixPathToWindowsPath(path) { | |||
| if (brackets.platform === "win") { | |||
| path = path.split("/").join("\\"); | |||
There was a problem hiding this comment.
I think we should write
path = path.replace(/\//g, '\\');
Also since we are converting path to Windows, should we ensure first char is a drive letter?
There was a problem hiding this comment.
path = path.replace(///g, '\'); this don't work , tried it.
Other suggestion to check first char is a drive done,
There was a problem hiding this comment.
Check this:
FileSystem.isAbsolutePath = function (fullPath) {
return (fullPath[0] === "/" || (fullPath[1] === ":" && fullPath[2] === "/"));
};
There was a problem hiding this comment.
Also checked, and this is working:
'C:/Users/gjha/Desktop/test.js'.replace(/\//g, '\\')
"C:\Users\gjha\Desktop\test.js"
'C:/Users/gjha/Desktop/test.js'.replace(RegExp('/','g'), '\\')
"C:\Users\gjha\Desktop\test.js"
There was a problem hiding this comment.
@jha-G made changes as above info.
added 2 commits
March 19, 2020 21:14
g-217
approved these changes
Mar 19, 2020
niteskum
added a commit
that referenced
this pull request
Mar 24, 2020
Path is converted to windows style when opening with external editor in win
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some Applications like Illustrator can not open file represented in Posix style. so converting path to windows style for windows platform.
@sobisht @narayani28 @jha-G please review.