This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Update Codemirror to version 5.25.2 #13331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I run the testsuite and there are quite a few failures... But they seem unrelated to this PR. |
ficristo
approved these changes
Apr 24, 2017
|
@ficristo I had exactly the same issue even in unit tests. In integration there were failure in find replace test cases even earlier, but very recently for unit tests I started seeing these other failures in native menu and low level io. We have to look at it some time to make sure we have a clean test run. |
petetnt
approved these changes
Apr 25, 2017
zaggino
approved these changes
Apr 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating CM to 5.25.2 to get the SCSS mode fix done @codemirror/codemirror5@2c46d1b.
This is required for PR #13295.
//Ping @ficristo @petetnt @zaggino for review.