This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix layout on narrow extension manager #13245
Merged
zaggino
merged 7 commits into
adobe:master
from
justinrusso:bugfix/extension_manager_responsive_fix
Apr 3, 2017
Merged
Fix layout on narrow extension manager #13245
zaggino
merged 7 commits into
adobe:master
from
justinrusso:bugfix/extension_manager_responsive_fix
Apr 3, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just tested it out, works for me. The implementation also looks good. 👍 |
saurabh95
approved these changes
Mar 31, 2017
@saurabh95 and @petetnt agreed. Works well, not a huge change. Has a nice little conditional that puts the right-sided elements under the tabs so everything is still usable regardless of the width. |
lkcampbell
approved these changes
Apr 3, 2017
👍 merged, thanks @justinrusso |
No problem, glad you liked it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added queries to stop the search and filter drop-down from overlapping the tabs when the window becomes too small, and from there, the search bar element will adjust in size
Ref issue: #13209