-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Prevent extensions from loading in test windows #1284
Conversation
…nit tests as a suite. Fix broken perf tests.
src/brackets.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this be overridden? Maybe this is worth adding as a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comment. this is to allow unit tests to modify which folders to load.
|
Done with initial review |
|
Thanks Randy. Just pushed my changes. I did a good amount of refactoring to for usage of encode/decode URI component. |
src/utils/Params.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this utility would be more useful if the url string were passed in as a parameter. That way it could be used for any url, not just the current document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an optional url parameter. Defaults to window.document.location.search.
|
Nice refactoring. Just a couple more minor comments. |
|
Thanks @redmunds. Updated the docs too. Ready for review. |
|
Looks good. |
Prevent extensions from loading in test windows
#1275