Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@jasonsanjose
Copy link
Member

#1275

  • Prevent extensions from loading in test windows
  • Separate extension unit tests as a suite
  • Fix broken perf tests

…nit tests as a suite. Fix broken perf tests.
@ghost ghost assigned redmunds Jul 19, 2012
src/brackets.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this be overridden? Maybe this is worth adding as a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment. this is to allow unit tests to modify which folders to load.

@redmunds
Copy link
Contributor

Done with initial review

@jasonsanjose
Copy link
Member Author

Thanks Randy. Just pushed my changes. I did a good amount of refactoring to for usage of encode/decode URI component.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this utility would be more useful if the url string were passed in as a parameter. That way it could be used for any url, not just the current document.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an optional url parameter. Defaults to window.document.location.search.

@redmunds
Copy link
Contributor

Nice refactoring. Just a couple more minor comments.

@jasonsanjose
Copy link
Member Author

Thanks @redmunds. Updated the docs too. Ready for review.

@redmunds
Copy link
Contributor

Looks good.

redmunds added a commit that referenced this pull request Jul 20, 2012
Prevent extensions from loading in test windows
@redmunds redmunds merged commit 03d2b45 into master Jul 20, 2012
@pthiess pthiess mentioned this pull request Sep 13, 2014
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants