Health Data Logs for 1.4 #11311
Health Data Logs for 1.4 #11311
Conversation
…kets. We aonly log the stantard extensions known by brackets[js,html, css, etc..]. All other extensions are ignored.
App start, module deps resolved, load proj, open file
|
@prafulVaishnav @prksingh Can we track the project size using the background file indexing work going on? |
|
@abose Travis is failing at the |
|
@nethip Fixed. |
…n/avg/max/sd. Also adding generic API to log health data given a hey
|
@marcelgerber @sprintr could you check this out. |
| @@ -144,6 +146,9 @@ define(function (require, exports, module) { | |||
|
|
|||
| sendHealthDataToServer() | |||
| .done(function () { | |||
| //We have already sent the health data, so can clear ll health data | |||
| //Logged till now | |||
There was a problem hiding this comment.
A space after // would be nice here and ll in clear ll health seems to be a typo.
|
Thanks @sprintr for reviewing this. I have made the changes. |
| @@ -528,6 +530,7 @@ define(function (require, exports, module) { | |||
| return handleFileOpen(commandData).done(function (file) { | |||
| var paneId = (commandData && commandData.paneId) || MainViewManager.ACTIVE_PANE; | |||
| MainViewManager.addToWorkingSet(paneId, file, commandData.index, commandData.forceRedraw); | |||
| HealthLogger.fileOpened(file.fullPath, true); | |||
There was a problem hiding this comment.
This way, we call fileOpened two times (one time for handleFileOpen, then for handleFileAddToWorkingSetAndOpen). Is it meant to be like this?
There was a problem hiding this comment.
Yes, it is meant to track twice, one log tracks all files opened to working set, and another the total of all files opened.
| if (!shouldLogHealthData()) { | ||
| return; | ||
| } | ||
| var fileExtension = FileUtils.getFileExtension(filePath), |
There was a problem hiding this comment.
I wonder if it makes sense to also log multiple file extensions, like in .min.js and .min.css (which are definitely the most common).
It'd be an interesting metric to see how many of the opened files are minified.
|
I've just committed a new approach to |
| } | ||
| }; | ||
|
|
||
| /** | ||
| * Returns the performance data as a tab deliminted string |
There was a problem hiding this comment.
Not your fault, but a typo anyways: deliminted
|
@marcelgerber liked your implementation, but |
|
The project size will be tracked by the new find in files update. As this is now blocking other health logs for 1.4, I am going ahead and merging this PR. |
| openedFileExt : {}, | ||
| workingSetFileExt : {} | ||
| }; | ||
| if (language.getId() !== "unknown") { |
There was a problem hiding this comment.
Belated, but: is there a reason we don't want to log unrecognized file extensions too? Seems like it'd be a useful way of identifying gaps in our default set of syntax highlighters & file-extension mappings...
There was a problem hiding this comment.
File names and extensions I think are personal information. So it felt like one step short of sending all filenames opened in brackets to the servers- which makes even me paranoid. 😖
Add performance-specific metrics to the Health Data Report. Things we want to start tracking:
tracks #11055