Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@sprintr
Copy link
Contributor

@sprintr sprintr commented Jun 23, 2015

Fixes a few typos in preferences description

CC: @abose

abose added a commit that referenced this pull request Jun 24, 2015
@abose abose merged commit 96f24bf into adobe:master Jun 24, 2015
@abose
Copy link
Contributor

abose commented Jun 24, 2015

Thanks @sprintr . merging.

@sprintr sprintr deleted the pref-desc-typos branch June 24, 2015 06:39
@rawat11
Copy link

rawat11 commented Jul 13, 2015

@sprintr Could you please check these strings (Do they hold specific meaning ?)

  • "True to allow unfiltered for in" (should it be translated as "True to allow unfiltering for inbound elements"?)
  • "True to allow stupidity"

@abose Can you check as well

@sprintr
Copy link
Contributor Author

sprintr commented Jul 13, 2015

"True to allow unfiltered for in" (should it be translated as "True to allow unfiltering for inbound elements"?)

True to allow unfiltered for in seems fine to me. Reference

"True to allow stupidity"

This can be changed to True if blocking ('...Sync') methods can be used. Reference

@rawat11
Copy link

rawat11 commented Jul 13, 2015

@sprintr Thanks. I do not have much idea on this.
If you are fine with first. then let it be like that. For second we can change it, leaving it to you.

@sprintr
Copy link
Contributor Author

sprintr commented Jul 13, 2015

In the review of #11318, All of True were changed to the JavaScript Boolean true, so should we do the same for default locale?

@rawat11 @abose @marcelgerber

@abose
Copy link
Contributor

abose commented Jul 13, 2015

@sprintr seems logical to use js boolean for me too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants