Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@Milliw
Copy link

@Milliw Milliw commented Jun 16, 2015

And replaced it with good old and correct word "aktualisieren"

And replaced it with good old and correct word "aktualisieren"
@marcelgerber marcelgerber changed the title Removing "denglisch" word "updaten" German Translation: Removing "denglisch" word "updaten" Jun 16, 2015
@marcelgerber
Copy link
Contributor

@MarcoWilli In order for us to be able to take this change, you need to agree to the Brackets Contributor License Agreement.

This somehow wonky wording has made me wanna change it, too, but I've not yet gotten around to submitting a PR. This is a welcome change!

@marcelgerber marcelgerber self-assigned this Jun 16, 2015
@Milliw
Copy link
Author

Milliw commented Jun 17, 2015

I can not submit the license agreement form because it says my email address is not valid! I use mail adress example@mydomain.rocks. Please fixe this -.-

@marcelgerber
Copy link
Contributor

@ryanstewart It looks like the correct-mail-address check doesn't consider the newly added, generic top level domains (like .rocks, in this case).

@abose
Copy link
Contributor

abose commented Jun 18, 2015

@prksingh I guess we have to touch the ancient ColdFusion scrolls at the CLA server to make this work?

@TomMalbran
Copy link
Contributor

If that is too hard, maybe we could add a cla exception? https://github.com/adobe/brackets/blob/master/tasks/cla-exceptions.json

@busykai
Copy link
Contributor

busykai commented Jun 19, 2015

@TomMalbran, the CLA must be signed. cla-exceptions.json is not for these cases (you either have to be a bot or still sign a CLA). This is actually urgent enough to fix the mail check.

@prksingh
Copy link
Contributor

I have created an issue for this here

@abose
Copy link
Contributor

abose commented Jun 19, 2015

The CLA check will take a bit of time to resolve, so moving out this PR from this release.
For the time being, we will not be able to accept generic TLD mail addresses for CLA checks.
@MarcoWilli We apologize for this inconvenience.

@abose
Copy link
Contributor

abose commented Jun 19, 2015

Tagging @nethip @ryanstewart for prioritizing this.

@Milliw
Copy link
Author

Milliw commented Jul 10, 2015

Hey guys. Do I need to do something or do we have to wait until the CLA is fixed?

@marcelgerber
Copy link
Contributor

Closing in favor of #11371, which includes these changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants