Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@coreice
Copy link
Contributor

@coreice coreice commented Jun 3, 2015

Added over 200 new strings and removed obsolete strings from older (pre 1.3) Bracket versions. Edited some existing strings to be more accurate. Tried to be as consistent as possible when translating certain jargon.

Added over 200 new strings en removed obsolete strings from older Bracket versions. Edited some existing strings to be more accurate. Tried to be as consistent as possible when translating certain jargon.
@marcelgerber
Copy link
Contributor

Thanks for your contribution!
You need to sign the contributor license agreement first, we can't take your changes otherwise.

@marcelgerber marcelgerber changed the title Update strings.js Update Dutch translation Jun 3, 2015
@abose
Copy link
Contributor

abose commented Jun 4, 2015

@coreice As brackets is an open source project, The contributor license agreement is for your protection as well as the protection of Brackets and its licensees; it does not change your rights to use your own Contributions for any other purpose.

@coreice
Copy link
Contributor Author

coreice commented Jun 4, 2015

@abose I'm aware of that. I hope my contribution will be approved.

@abose
Copy link
Contributor

abose commented Jun 4, 2015

@coreice have you signed the CLA?

@marcelgerber
Copy link
Contributor

@abose He has (according to grunt cla-check --user=coreice), but the Travis build fails either way for some reason. I've restarted it twice now without success.
E: Oh, I see, it failed for an other reason now. At least the CLA check works 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this line is indented one space too much

@marcelgerber
Copy link
Contributor

@ispieter @githrdw Would you mind doing a quick review on these changes & additions to the Dutch translation?

@abose
Copy link
Contributor

abose commented Jun 9, 2015

@coreice Could you update this PR.
@ispieter Are there any specific modifications that need to be done here?

@ghost
Copy link

ghost commented Jun 9, 2015

Yes, I see several errors in the translations. @abose, what is the best way to mark these? Should I leave a comment on all of them?

@coreice
Copy link
Contributor Author

coreice commented Jun 9, 2015

If you can mark these errors I will fix them.

@marcelgerber
Copy link
Contributor

@ispieter It's best to add a line note to every line you'd like to be changed.
It'd be very helpful if you could include both an explanation of what's wrong in your opinion and a suggested correction.

@coreice Please make sure you fix the linting errors and the missppelled key, too.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'stringen/substringen' are no Dutch words. Perhaps 'teksten/deelteksten' is a better alternative.

@ghost
Copy link

ghost commented Jun 9, 2015

These are the things that I found. The rest seems fine to me. :)

@coreice
Copy link
Contributor Author

coreice commented Jun 9, 2015

Thanks a lot, I will process them :). I hope it will be ready this week but I've a busy schedule so it also could be next week.

@abose
Copy link
Contributor

abose commented Jun 16, 2015

Thanks @ispieter for reviewing this. @coreice Did you get a chance to look into this? Brackets will have a release within the next two weeks.

@coreice
Copy link
Contributor Author

coreice commented Jun 18, 2015

@abose Just returned home from a convention. Will be working on it now :). Do you want me to create a new edit and pull request after I'm done?

Edit 16.02 gmt+2: done with editing the errors.

@abose
Copy link
Contributor

abose commented Jun 18, 2015

👍 Editing this PR would be good for other reviewers to keep track of the changes.

Fixed some errors reported by @marcelgerber and @ispieter. Also saw some other errors during the process.

Line 133: Changed "Verwijdering" into "Verwijderen".

Line 251, 485, 486, 500, 521, 522 & 589: These lines weren't (correctly) translated in the previous version of my translation.
@coreice
Copy link
Contributor Author

coreice commented Jun 18, 2015

Updated the PR. Thanks for checking @marcelgerber & @ispieter, there were some stupid mistakes in the previous one. I hope this one will be better :).

@abose abose added this to the Release 1.4 milestone Jun 19, 2015
@marcelgerber
Copy link
Contributor

@ispieter Does this look good to you?

@marcelgerber
Copy link
Contributor

You should also update the SHA comment at the very bottom. This is based on 50cbe1b (50cbe1b8848786c6be27d4788e4b6a367244abc2), I guess.

Fixed SHA.
@coreice
Copy link
Contributor Author

coreice commented Jun 20, 2015

@marcelgerber You're right. Fixed the SHA comment.

@ghost
Copy link

ghost commented Jun 21, 2015

Yes, looks good to me.

@marcelgerber
Copy link
Contributor

Thank you @coreice @ispieter.
Merging.

marcelgerber added a commit that referenced this pull request Jun 21, 2015
@marcelgerber marcelgerber merged commit 53165a1 into adobe:master Jun 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants