Move descriptions to their preferences

[sprintr]

All the descriptions of the preferences have been moved to their preferences and we no longer have data.json 😄

[marcelgerber]

Maybe also add a comment stating what this data is used for.

[abose]

Fixes part of #11200

[busykai]

This should not specify value.

[TomMalbran]

Maybe it could autocomplete with the registered linters? That would be cool.

[busykai]

Yes, it could be done, I guess. My point, though, it should not have default in the property definition (there's no default for this pref).

[sprintr]

Ok, I will add that.

[busykai]

Just to be clear: what I am asking you to do is to remove line 617. Hinting on registered plugins is not necessarily needed for this PR.

[marcelgerber]

If you could just go ahead and remove this line (and also squash commits if you like), I could merge this PR in.

[sprintr]

@abose @marcelgerber I think it is ready for merging in.

[TomMalbran]

This should be {?Array.<string>}.
Or maybe it should return an empty array on the null case.

[abose]

why is codehint.TagHints is removed?

[sprintr]

It is still there, I added description to it.

[marcelgerber]

We should also listen to the LanguageManager events languageAdded and languageModified (?).

[marcelgerber]

You could do the same for the list of themes by listening to ExtensionManagers' statusChange event.

[sprintr]

statusChange gets fired every time an extension gets loaded. We would need an event that is fired only when an extension gets installed/uninstalled, so we can update our preferences data.

[TomMalbran]

Does it makes a big difference to have this once instead of calling it when getting the list of hints?

You are already doing it for the code hint providers. So I think we can do something similar for both languages and themes.

[sprintr]

We can check if the AppInit.appReady has been called, after that we can update our preferences, theme data on each statusChange event.

[marcelgerber]

AFAIK, all extensions are loaded after appReady has been called.

[sprintr]

Not the ones you install after that, we need another event for that.

[sprintr]

@marcelgerber I gave this a shot but since statusChange event is fired before the theme gets registered, ThemeManager.getAllThemes() still provides the old list of themes. But it works for getting code hints from newly installed extensions.

[sprintr]

@marcelgerber @TomMalbran Theme hints are not cached anymore, that should fix the issue of themes. Languages will still use languageAdded event.

[TomMalbran]

@sprintr I still don't see the point of having a cache of something that could be grabbed at the point of getting the hints like it is done with the code hint providers. getLanguages copies the object, but since you will have to iterate through the list eventually to create the ui, should be fine to get them on getHints when you actually need them. And the same goes for the themes, and maybe even the preferences. Seems easier than keeping a copy that needs to be synched.

[sprintr]

@marcelgerber It now returns empty array.

[marcelgerber]

Merging. Thanks @sprintr.

[abose]

@sprintr the jasmine unit tests suite is failing after this PR merge commit. with the following error
Uncaught Error: Module name "language/CodeInspection" has not been loaded yet for context: _
Usually its a good idea to run the unit tests suite to catch errors like this :)

[sprintr]

@abose Debugging this right now. Seems a tricky one.

[abose]

Thanks @sprintr for the fix.
@marcelgerber Usually we go through a pass of unit tests, integration and extension tests as baseline(+additional test cases) before merging any pull requests. 🚕

[marcelgerber]

@abose I'm sorry. I've looked through all the changes and, well, I didn't expect unit test failures as all this PR changed is the added descriptions and one newly added function.
I'll be more careful the next time.

[abose]

@marcelgerber No probs :) We also used to do the same thing until we noticed that in some cases even minor changes could sometimes cause a ripple. So just stuck to doing the basic smokes just before merge.