This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Store code-folding view state in project-specific buckets #10919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
organization. If we later offer a way for users to delete stored data for a project, this ensures code folding data will be cleaned up along with everything else. (This is also how we store Quick Edit expand/collapse state, which is very similar).
Contributor
|
#10869 will be fixed by this change list. Testing the changes as this would be good to go in today's prerelease. |
Contributor
|
Thanks for submitting this fix @peterflynn. The state.json has the fold stated bucketed in the project prefs now, Also all the unit tests are passing. Also the fold states are persisted across project switch and brackets restart. |
abose
added a commit
that referenced
this pull request
Apr 17, 2015
Store code-folding view state in project-specific buckets
Contributor
|
looks great 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store code-folding view state in project-specific buckets for cleaner organization. If we later offer a way for users to delete stored data for a project, this ensures code folding data will be cleaned up along with
everything else. (This is also how we store Quick Edit expand/collapse state, which is very similar).
I suggested this originally in #10850 (comment). It's not super critical, but it will be much easier to do now (before code folding initially ships) -- if we did this later, we'd have to write and test additional preferences migration code.
@thehogfather does this look ok to you?