This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Select tree node on right-click #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
|
It looks like other code editors don't toggle folders on right click. If it's not trivial to change right now I think we can land this pull request and log a bug to change that functionality in another spring. |
src/project/ProjectManager.js
Outdated
Contributor
There was a problem hiding this comment.
In the future when the tree supports multiple selection we don't want to deselect all here in order to allow the user to shift-select multiple files and execute a command from the context menu. Maybe leave a comment about this here for future reference?
Contributor
|
done reviewing |
Contributor
Author
|
Fixed folders from toggling open (or closed) on right-click. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tvoliter
This fixes issue #1069.
Note that this makes right-click behave exactly the same as left-click, which means that the open/close state of folders is toggled. Is that OK, or should we select without toggling?