Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Brackets Box/Flex CSS Update #10908

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

puzzledShark
Copy link

Presently brackets is using an outdated version of flex, due to this the sidebar is not rendered properly within firefox.

Refer to: https://github.com/humphd/brackets/issues/180 for more information on this issue/fix explaination

@abose
Copy link
Contributor

abose commented Apr 15, 2015

@KeniMorri it looks like you have not signed the BRACKETS CONTRIBUTOR LICENSE AND DISTRIBUTION AGREEMENT

@le717
Copy link
Contributor

le717 commented Apr 15, 2015

I'd recommend holding off on merging this until Linux gets CEF 2721 so nothing breaks on that platform (and I think I heard something about that possibly happening in 1.4?).

@peterflynn
Copy link
Member

Earlier, flexbox caused us some very bad performance issues. We should check:

a) whether this PR causes any performance regressions
b) whether this PR causes any performance improvements (maybe newer syntax uses a newer, faster impl under the hood) -- and if so, is it safe to start using flexbox more widely in the Brackets UI after this?

@puzzledShark
Copy link
Author

Updated because I forgot to include prefixes for safari
@abose my bad, I've signed it now

@abose abose added this to the Release 1.4 milestone Apr 18, 2015
@abose
Copy link
Contributor

abose commented Apr 18, 2015

Marking this for 1.4, will update if there is any performance issues as peter pointed out.

@nethip nethip assigned nethip and abose and unassigned nethip Apr 20, 2015
@nethip nethip modified the milestones: Release 1.5, Release 1.4 Jul 27, 2015
@abose
Copy link
Contributor

abose commented Sep 16, 2015

I see that there is an overlap in hte project tree rendering.
image

@redmunds
Copy link
Contributor

@abose I just ran into a similar problem on an internal project (so I can't post any links). The solution for my particular case was to specify the min-height as the flex-basis parameter instead of auto, which is what Brackets appears to be doing -- see the .flex-item() mixin.

@abose
Copy link
Contributor

abose commented Oct 4, 2015

Thanks @redmunds .
Waiting for PR to be updated with the fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants