This repository was archived by the owner on Sep 6, 2021. It is now read-only.
HealthDataRefactoring #10849
Merged
HealthDataRefactoring #10849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prafulVaishnav
commented
Apr 8, 2015
prafulVaishnav
commented
- Checking with testEnvironment so as to avoid collision with other unittest cases.
- Making the preference name more clear
- Using Date.now() instead of new Date().getTime()
- Remove separate object to store userExtensions instead using ExtensionManager.extensions
- Change function name to be more clear
…unittest cases. 2. Making the preference name more clear 3. Using Date.now() instead of new Date().getTime() 4. Remove separate object to store userExtensions instead using ExtensionManager.extensions 5. Change function name to be more clear
Contributor
There was a problem hiding this comment.
You can use Date.now() here too (and below)
Contributor
There was a problem hiding this comment.
Do you need this variable? You are not changing it anywhere
Contributor
|
Looks good. Merging. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.