This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix console deprecation warnings in core code #10729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
Contributor
|
Sorry about this mess again. I did a Find in Files search from within Brackets and somehow I must have overlooked these. :( |
src/editor/EditorStatusBar.js
Outdated
Contributor
There was a problem hiding this comment.
Just as I saw that change, I think you can remove one level of indentation here.
Member
Author
There was a problem hiding this comment.
Makes sense -- could go back two levels, even. Change pushed.
Contributor
|
@peterflynn Anything preventing this from being merged? |
Member
Author
|
@le717 It needs to be reviewed by another committer before it can be merged |
peterflynn
changed the title
zaggino
added a commit
that referenced
this pull request
Mar 29, 2015
Fix console deprecation warnings in core code
Contributor
|
Reviewed and merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some moved APIs that were left over from cleanup PR #10641.
Looks like these got missed -- fyi @le717. My bad too since I didn't notice this during the code review.