This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix event chaining with .off() #10024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'll go ahead and merge this so it isn't forgotten, doesn't look like this needs a discussion. |
zaggino
added a commit
that referenced
this pull request
Nov 27, 2014
Fix event chaining with .off()
peterflynn
added a commit
that referenced
this pull request
Dec 2, 2014
ingorichter
added a commit
that referenced
this pull request
Dec 3, 2014
Unit test for PR #10024 (event chaining fix)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported as brackets-userland/brackets-git#820.
.off(),.on()and.one()should alwaysreturn this, but there was one case where.off()didn't.Also, moved the condition a few lines - no big deal.