jslint version is out of date

[markmcintyre]

The version of jslint bundled in the default extensions is out of date (id 2347ec4, last updated 2011-12-21), and doesn't report on several types of programming errors. This should be updated to the latest version.

[ingorichter]

Dropping in the latest master causes a lot of warnings in the Brackets source. I think we should fix them, since they are low hanging fruits (especially the formatting and unused variables statements).

[marcelgerber]

The new JSLint version introduces some linting errors that'd change our code style, for example unnecessary else after disruption.
I'd like to fix those, but I don't know whether we actually want to change the code (maybe accompanied with Coding Conventions changes) or just use a linting flag.
Another thing are the define(function (require, exports, module) { lines, where module isn't used very much, but these lines are consistent in the whole project. JSLint wants to disrupt them (unused variable).

[lkcampbell]

+1 for being able to find unused variables.

[ingorichter]

I would be more than happy to make adjustments to the coding style and get these fixed. I'm going to create an overall report and ask the core team/committer about their opinions.
And yes @lkcampbell, me +1 too.

[TomMalbran]

This is almost a dupe of #4462. I made a PR long time ago to update JSLint: #4557. But is totally out of date now. It was closed since the team wanted to switch to JSHint as the default linter for Brackets. When that is done (Brackets provides a default JSHint extension), the JSLint extension could be updated without issues in the Brackets codebase.

[redmunds]

We're considering making this update for the Promises Upgrade feature (trello/waffle), so I started a randy/jslint-update branch.

[redmunds]

@marcelgerber

The new JSLint version introduces some linting errors that'd change our code style,
for example unnecessary else after disruption. I'd like to fix those, but I don't know
whether we actually want to change the code (maybe accompanied with Coding
Conventions changes) or just use a linting flag.

That can't be fixed with a flag, so we'd have to fix the code (which I think is a good idea). The fix is simple and there doesn't seem to be too many instances of it. Since JSLint will be flagging it as an error, then we probably don't need to mention it in Coding Conventions as a reminder :)

[dangoor]

Our current plan is to use JSHint and we'd welcome any help in that direction.

[markmcintyre]

Hold up here. This issue is about upgrading the JSLint dependency in Brackets independent of any coding standards used in the Brackets codebase. There are projects other than Brackets that uses Brackets, after all.

Is the suggestion here that all projects using Brackets must use the old version of JSLint because the Brackets team isn't yet ready to transition their own code to JSHint?

[TomMalbran]

@markmcintyre Even if that might be the case, there is no reason to not create a new JSLint extension with the newest version and start using it instead of the default one. I am not sure why none tried that yet.

[markmcintyre]

Ah, I understand. Thanks, @TomMalbran.
Since no one else has tried it yet, I'm tempted to give it a go myself.

[markmcintyre]

I've created a new JSLint extension that adds support for the latest version of JSLint (2014-07-08 as of this writing). For any existing or future followers of this issue, the extension is available here, as well as in the Brackets Extension Registry under the name "JSLint."