Extension Manager returns 404 error for when extension version contains "+"

[jasonsanjose]

I posted an extension zip named jasonsanjose.brackets-sass-0.4.1+sha.fc425b5.zip. The link from the registry https://brackets-registry.aboutweb.com/ points to https://s3.amazonaws.com/extend.brackets/jasonsanjose.brackets-sass/jasonsanjose.brackets-sass-0.4.1+sha.fc425b5.zip which returned a 4040.

I rebuilt my extension to drop the +sha... metadata.

Since we explicitly link to semver here https://github.com/adobe/brackets/wiki/Extension-package-format#packagejson-format, we should either note the exception for + plus signs or update the registry to support plus signs.

[jasonsanjose]

FYI I submitted a new version https://s3.amazonaws.com/extend.brackets/jasonsanjose.brackets-sass/jasonsanjose.brackets-sass-0.4.2-51.zip that uses the commit count as a prerelease number instead of the SHA as build metadata.

[marcelgerber]

The only issue here is that + should be URLencoded to %2B.
This link works: https://s3.amazonaws.com/extend.brackets/jasonsanjose.brackets-sass/jasonsanjose.brackets-sass-0.4.1%2Bsha.fc425b5.zip

[dangoor]

Reopening. This is fixed but not deployed.

[ingorichter]

Closing. This got deployed in the meantime.