This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Find in Files results semi-broken after canceling search bar #6966
Comments
Last reviewed for 1.0 milestone added. |
Reassigning to me. This isn't fixed yet in my branch, but should be easy to fix. |
Fix is in #8171 |
Actually, will try to do a different fix where I instantiate a new clean SearchModel instead of clearing the old one. |
njx
added a commit
that referenced
this issue
Jun 19, 2014
…FilesUI doesn't need to touch the model before the search starts (for #6966)
Better fix in #8174. |
Confirmed. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Result:
3 - results don't update
4- exception thrown
This is because
_doFindInFiles()
resets the search state immediately, instead of waiting until the search is begun. We should either move that code later, or close the results panel as soon as the Find in Files bar is reopened.The text was updated successfully, but these errors were encountered: