Should place extensions to update on top of "installed" list #6634
Comments
|
@SAplayer Yeah, I think that's a great idea! |
ghost
assigned 
|
Sorry, I tried this, but I didn't get far as the .updateAvailable flag is set later on (async). |
|
@SAplayer I was checking the code and each item is rendered in |
|
I think by the time I've always found it a little weird that InstalledViewModel happens to depend on RegistryViewModel loading to mix in some extra info to its objects, and isn't really fully initialized until that happens. If we wanted to be ambitious we could go as far as cleaning that up a bit as part of this work :-) But certainly not required. |
|
@TomMalbran No, these functions are only affecting the @peterflynn It would be a lot easier if we did this work before doing this. But I can't do it as I'm not used to Async stuff and things like Deferred objects and so on. |
|
+1 👍 |
marcelgerber
changed the title
Updated design Check registry at most once a day Remove updated and uninstalled extensions from update list Use new icon sprite Calculate when an actual update should be launched Calculate updateCompatible for extensions toggle icon even when registry are downloaded through extension manager checkForUpdate is now called directly on the startup as it was before combine the functions download only if there're no updates available delete icon that is no longer user This sorts installed extensions by updateAvailable (#6634) align = in exports add an empty line use localeCompare instead of ifs use Array instead of array for preferences do not convert new preferences move event listener to the bottom of the file move function to the bottom to make JSLint happy count only compatible updates for notification icon add comments fix tests that were failing after changes to the model.notifyCount fix issue when update button is disabled but newer compatible version (not latest) exists add tests for ExtensionManager.getAvailableUpdates() method add tests for ExtensionManager.cleanAvailableUpdates() method move new tests
Updated design Check registry at most once a day Remove updated and uninstalled extensions from update list Use new icon sprite Calculate when an actual update should be launched Calculate updateCompatible for extensions toggle icon even when registry are downloaded through extension manager checkForUpdate is now called directly on the startup as it was before combine the functions download only if there're no updates available delete icon that is no longer user This sorts installed extensions by updateAvailable (#6634) align = in exports add an empty line use localeCompare instead of ifs use Array instead of array for preferences do not convert new preferences move event listener to the bottom of the file move function to the bottom to make JSLint happy count only compatible updates for notification icon add comments fix tests that were failing after changes to the model.notifyCount fix issue when update button is disabled but newer compatible version (not latest) exists add tests for ExtensionManager.getAvailableUpdates() method add tests for ExtensionManager.cleanAvailableUpdates() method move new tests
|
@zaggino fixed this. Thank you! |
Currently when there are updates to extensions available in the installed list, they are still sorted alphabetically. It would be much better if the extensions to update where the first ones:
Screen:
The second extension to update is out of view.
I'd try to get a PR ready as soon as I got your ok.
The text was updated successfully, but these errors were encountered: