Untitled document remains in working set after save as

[jasonsanjose]

1. File > New, confirm Untitiled-1.js
2. Save
3. Specify a new file name foo.js
4. Observe both files are present

Expected: Untitled-1.js should have been removed from the working set.

I believe this is due to the changes in WorkingSetView.js here #4437. See handleFileRemoved and the new suppressRedraw arg.

[jasonsanjose]

I've only been able to reproduce this on my mac. Can't repro on win and @bchin couldn't repro on either.

[peterflynn]

@jasonsanjose Was foo.js outside the project root? If so then it's definitely the same cause as #4484 (the subject of PR #4479)...

[jasonsanjose]

Inside the project root. It appears at the root of the Getting Started project tree in the screenshot.

[bchintx]

I've updated PR #4479 to fix a couple of downstream issues. Using that branch, I'm still not seeing this issue on either a Windows or Mac build. Perhaps this problem was already fixed elsewhere?

[peterflynn]

@jasonsanjose I was able to get something similar with these steps:

1. New untitled document
2. Select some other file in the folder tree (not working set)
3. Save All

In general that'll happen anytime the selection indicator lies outside the working set. But I don't think you could ever hit that with the Save As command, and also in this case the saved "titled" doc isn't added to the working set at all... so it seems like a different bug. (One that I think is fixed, btw, as a side effect of @bchintx's PR #4514).

[njx]

@jasonsanjose - seems like it's not clear whether this bug has been fixed yet by the various pull requests that have been merged; can you see if it still repros for you in the latest master?

[jasonsanjose]

Can't reproduce in master. Closing.