First Find result not vertically centered in this case

[redmunds]

I found a case where it seems like the Find results should be vertically centered, but it is not:

1. Copy the text "addMeasurement" (without quotes) so that it's on your clipboard
2. Open brackets.js
3. Ctrl-End (or Cmd-down) to do to end of file
4. Ctrl/Cmd-F to invoke Find dialog
5. Ctrl-V to paste in search argument

Results:
Brackets auto-searches, finds the instance on line 109, and scrolls doc to line 109 is at the top of the editor

Expected:
Line 109 is vertically centered in editor as it is when you start same search from top of file.

[pthiess]

@dangoor , medium priority

[dangoor]

Here's the problem...

The first match is not supposed to center the result if it appears at the top (from FindReplace.js in findNext):

            var centerOptions = (isFindFirst) ? Editor.BOUNDARY_IGNORE_TOP : Editor.BOUNDARY_CHECK_NORMAL;
            editor.setSelection(cursor.from(), cursor.to(), true, centerOptions);

That was added to avoid unnecessary scrolling (go to the top of one of our files and search for "permission" to see what I mean). I think we need to add another case in there for when it's a first match but it appears farther down in the file.

[dangoor]

Nominating for sprint 27 (if this is actually medium priority, it would be good to knock it off the list).

[JeffryBooher]

Taking this one to try to get it fixed in 27

[JeffryBooher]

I have a fix but it requires a change to codemirror which I will bring up at tomorrow's standup

[JeffryBooher]

@gruehle helped me find a fix that doesn't require changes to codemirror

[JeffryBooher]

This needs a new owner since @redmunds is out

[jasonsanjose]

Confirmed fixed. Closing.