GB18030: Mac: Brackets cannot open folder successfully with “Error loading project” message when folder contains a file named with GB18030 characters.

[Zhuyun]

Method:

1. Install Brackets and launch Brackets.
2. Create a new folder, and copy a file named GB18030 characters (for example: 郎u+F9 2C) to the folder.
3. Click File -> Open folder.
4. Select this new folder to open.

Result:
Brackets cannot open folder successfully with “Error loading project” message. Please refer to below screenshot for details.

Note:
• Brackets can open folder successfully if the file name contain all GB18030 characters except special characters (for example郎u+F9 2C).
• Brackets can open the file in folder successfully with Click File -> Open.

Env: MacOSX
Language: SC
Build: sprint20 5744

Screenshot:

[pthiess]

Bug seems limited to special characters and folders. Mark it a low priority @RaymondLim

[iwehrman]

I can't reproduce this with Sprint 22 at a237877.

[RaymondLim]

You should be able to reproduce it if that character is used in your folder, not in the file name.

[iwehrman]

Still works fine for me with the character in the folder name. I could be doing something wrong though!

[Zhuyun]

Still open in sprint 22 6428 with opening a folder which included a file named with 郎u+F9 2C in it. Also reproduced on Japanese platform.

[iwehrman]

Ah, yes, I can reproduce it now. I foolishly thought I could just copy and paste that character, but at some point it must have been converted to something other than u+F9 2C. Sorry!

[iwehrman]

I spent a little time looking into this. The problem arises while reading file entries to render the project manager tree. Unsurprisingly, the root cause is the shell's inability to stat a file with the GB18030 characters in the filename. Rendering the project tree then fails because there was an error statting a single file. Obviously we'd like to fix the shell so that it can stat such files, but in the meantime I wonder if it makes sense to relax NativeFileSystem.readEntries to return in the errback the list of files that were statted without issue, instead of just rejecting the master promise. I just submitted a pull request for discussion that does just this.

[pthiess]

We'll never support all possible encodings nor character sets, but we should fail gracefully - which is why I set it to FBNC.

[pthiess]

@RaymondLim FBNC

[julieyuan]

As this issue has been fixed for a long while, closing it. Here is the snapshot for reference(verified with build 0.36.0-10932 ):