Disk usage leak in ProjectManager: welcomeProjects grows forever

[peterflynn]

I got a weird exception in Brackets tonight: QUOTA_EXCEEDED_ERR in PreferencesManager. It was trying to save an 887 KB JSON string.

After some investigation, I found this prefs key to be the problem: prefStorage["com.adobe.brackets.ProjectManager"].welcomeProjects

My welcomeProjects array is 11918 items long. They all point to the same exact folder.

I haven't cleared my cache in a long while, so I assume it's just been tacking on one entry per reload / project-open cycle for the whole time.

It also seems problematic that our prefs store is limited to < 900 KB. It seems like eventually we'll hit that wall for legitimate reasons too. We should see if there's a CEF API that will let us increase the limit.

[njx]

Ugh. To me for sprint 20.

[pthiess]

Reviewed

[gruehle]

FBNC, back to @peterflynn to close.

[peterflynn]

Confirmed. The 388 duplicates I'd accumulated since last night were all swept away after picking up this change, and the array has stayed at length 1 after that.

It turns out the list of dupes actually grew faster than I thought: you get 1 added per launch/reload, but you get N added per project reopen (1 per entry in the Recent Projects dropdown, since each dropdown item is checked against isWelcomeProjectPath() when the dropdown is rendered).