Inline CSS editor UI breaks if menu bar height changes when switching files

[joelrbrandt]

If the Brackets window is sized appropriately, the height of the menu bar can change when the user switches files. For example, if one file has a long name and one has a short name, the menu bar will "wrap" onto two lines for the long name but not for the short name.

If an inline editor is open and the user switches files and then switches back, and the menu bar resizes as a result, then the inline editor UI gets messed up.

Steps to reproduce:

1. Make an html file with a long name and a css file with a short name.
2. Size brackets so that when the html file is displayed, the menu bar is two lines long, but when the css file is displayed, the menu bar is only one line long
3. Switch to the html file
4. Open an inline editor
5. Switch to css file
6. Switch back to html file

Result:

Inline editor UI is messed up

Expected:

Not messed up

Images:

1. Initial inline editor with tall menu bar: http://cl.ly/image/2916261x3l2w
2. Switch to file with short menu bar: http://cl.ly/image/0i022G43171B
3. Switch back to first file, ui messed up: http://cl.ly/image/3A1w3J2A1G39

[peterflynn]

We do refresh the editor height whenever the toolbar height changes (see the call to resizeEditor() in DocumentCommandHandlers), so in theory this should behave similarly to the editor's height changing due to a window resize.

[pthiess]

Reviewed - @jasonsanjose
We may think about a centralized broadcast notification mechanism on layout changes. Might be part of the effort to remove Flexbox - may chat with NJ for ideas.

[jasonsanjose]

Oops. Didn't mean to auto close. FBNC @joelrbrandt.

[joelrbrandt]

Confirming fixed. Thanks @DennisKehrig !

[DennisKehrig]

Thanks for the reviews!