Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update strings for 1.5 #202

Merged
merged 2 commits into from
Oct 8, 2015
Merged

Update strings for 1.5 #202

merged 2 commits into from
Oct 8, 2015

Conversation

abose
Copy link
Contributor

@abose abose commented Oct 7, 2015

No description provided.

@nethip
Copy link
Contributor

nethip commented Oct 8, 2015

This LGTM. We should get this in ASAP as this is holding LOC process. So if anyone has any suggestion please suggest ASAP. Thanks!

nethip added a commit that referenced this pull request Oct 8, 2015
@nethip nethip merged commit 3193292 into master Oct 8, 2015
@abose
Copy link
Contributor Author

abose commented Oct 9, 2015

tagging @marcelgerber @pthiess @ingorichter @TomMalbran @jbalsas
for update strings translation

@marcelgerber marcelgerber deleted the abose/release1.5 branch October 9, 2015 21:18
"description": "CSS code hints are now available for style elements inside PHP files."
},
{
"name": "Remember Linter collapsed",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nethip The grammar here is wrong. Can we change to: "Remember Collapsed Linters"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@peterflynn
Copy link
Member

Is it worth calling out either of these patches?

@nethip
Copy link
Contributor

nethip commented Oct 12, 2015

@peterflynn Thanks for reviewing these strings. I will raise a PR with all of the changes you have suggested.

About adding two more entries; we have already gone through the LOC process to get update strings for other locales. Adding these will result in running through our LOC process again, which is time consuming. Is it better to leave have these strings included in the release notes page or do we want to explicitly mention them in the update strings?

@nethip
Copy link
Contributor

nethip commented Oct 12, 2015

@peterflynn Raised the PR #204 . Please review it and merge it, if it looks fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants