Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
419991c
VS2015: fix some warnings
ficristo Feb 6, 2016
c54a675
Updated gyp to 697933c2e3b3ffdd6949df3c2fa3613489e01175
ficristo Jan 31, 2016
a28fe08
Reapply "Fix directory copy for gyp on Windows"
ficristo Apr 2, 2016
d3d14bc
VS2015: add link libraries
ficristo May 6, 2016
82811d2
Updating verison number to 1.8 on master
nethip May 23, 2016
58a7d05
Merge pull request #554 from adobe/prashant/1.8vUpdate
swmitra May 23, 2016
58a11d2
Remove 'python2' from gypCommand
ficristo May 31, 2016
d03b45e
Moved client_switches files under a new common folder
ficristo Jun 2, 2016
e43d526
Merge pull request #559 from ficristo/client-switches
nethip Jun 21, 2016
7cf5fa6
Merge pull request #552 from ficristo/win-link-libs
nethip Jun 21, 2016
4441bd8
Removed string_util since is unused
ficristo May 30, 2016
b68893f
Merge pull request #556 from ficristo/remove-string-util
nethip Jun 21, 2016
498db40
Replaced util macros in favour of cef_helpers|cef_logging ones
ficristo May 30, 2016
c22d298
Mimic logic to define the OS
ficristo Jun 21, 2016
15c0f8e
Merge pull request #557 from ficristo/remove-util
nethip Jun 21, 2016
b680235
Merge pull request #549 from ficristo/VS2015-fix-warnings
nethip Jun 22, 2016
3046a38
Merge pull request #546 from ficristo/update-gyp
nethip Jun 22, 2016
ad2224e
Update common.gypi
nethip Jun 22, 2016
261d6a8
Rework a bit appshell gyp files
ficristo Jun 22, 2016
d85d47b
Merge pull request #560 from adobe/nethip/vs2013-fix-linker-error
nethip Jul 1, 2016
18efd12
Change path of xdg-open to match opn
ficristo Aug 10, 2016
ed1ad02
Merge pull request #563 from ficristo/opn
Aug 10, 2016
ad0b912
Compress .png files using Zopfli
Aug 11, 2016
2191560
Update compatibility.manifest for Windows 10
ficristo Aug 14, 2016
d2b43f8
Enable paste command
ficristo Aug 14, 2016
1e73889
Merge pull request #566 from ficristo/compatibility
Aug 15, 2016
b990d72
Update .gitignore
ficristo Aug 16, 2016
b3b2de2
Merge pull request #569 from ficristo/update-gitignore
ingorichter Aug 17, 2016
194ed8a
Merge pull request #561 from ficristo/appshell-gyp
ficristo Aug 17, 2016
975df9e
Move resource(_util*) under a new browser folder
ficristo Jun 22, 2016
b88442e
Merge pull request #570 from ficristo/resource
Aug 18, 2016
da088ef
Set release to 1.8 where it wasn't set
Aug 18, 2016
742f2a2
Add client_types.h, match gtk gyp inclusion of cefclient
ficristo Aug 18, 2016
b5144f0
Make OSX compile again.
Aug 23, 2016
f30eb33
Merge pull request #571 from ficristo/client-types
ficristo Aug 24, 2016
09ad447
Merge pull request #565 from adobe/marcel/zopfli-png
ficristo Aug 25, 2016
3a2ce2f
Switched from JSHint to ESLint
ficristo Dec 9, 2015
cebe349
Merge pull request #542 from ficristo/eslint
zaggino Aug 25, 2016
ac6956f
Merge pull request #573 from adobe/release
ficristo Aug 28, 2016
696673f
Merge pull request #567 from ficristo/paste
Sep 1, 2016
fe347d9
update shell node version to 6.3.1 (#543)
zaggino Sep 3, 2016
7baf97b
Remove define OS, they are already in config.h
Sep 14, 2016
9fe27a1
Make the license evergreen
Sep 14, 2016
61ef6e7
Remove trailing whitespaces from license comments
Sep 14, 2016
369ec62
Reorder a bit the includes and add a newline after the license
Sep 14, 2016
89b47f8
Include config.h wherever is necessary
Sep 14, 2016
5771aad
Add missing include
ficristo Sep 14, 2016
dd88e9c
Merge pull request #576 from ficristo/cleanup
ficristo Sep 15, 2016
a4ab798
Merge pull request #577 from ficristo/remove-define-os
ficristo Sep 15, 2016
4579bc3
Add missing include and fix path libcef.so
ficristo Sep 15, 2016
201af6b
Merge pull request #578 from ficristo/linux-fix
ficristo Sep 15, 2016
3c0b7e5
Ignore only toplevel folder and add out folder too
ficristo Sep 19, 2016
3deab85
Merge pull request #580 from ficristo/gitignore
ficristo Sep 25, 2016
ef7a13e
Move AppShellExtensionHandler and StContextScope out of client_app
Sep 13, 2016
a2eaeeb
Move fixupKey where it is used and fix headers inclusion
ficristo Sep 28, 2016
bc6fa8e
Merge pull request #581 from ficristo/client_app-split
ficristo Oct 1, 2016
52d883d
Merge pull request #583 from ficristo/move-fixupKey
ficristo Oct 1, 2016
62ec72f
Import cefclient-2623 code and compile it only on Linux
ficristo Oct 2, 2016
6fa7509
Merge pull request #584 from ficristo/cefclient-linux
ficristo Oct 4, 2016
6710571
Renamed client_app_<platform> to appshell_helpers_<platform>
ficristo Oct 1, 2016
9a12246
Move AppGetProductVersionString and AppGetChromiumVersionString in ap…
ficristo Oct 1, 2016
7173d21
Merge pull request #585 from ficristo/appshell_helpers
ficristo Oct 6, 2016
3a91686
Init command_line directly in cefclient_<platform>
ficristo Oct 2, 2016
21daa05
Merge pull request #586 from ficristo/command-line
ficristo Oct 6, 2016
e5c9719
Move more things from cefclient_gtk to appshell_helpers
ficristo Oct 6, 2016
9cffd27
Merge pull request #588 from ficristo/appshell-move-more
ficristo Oct 7, 2016
1480d1d
Fixing compilation error in VS2010 and VS 2013
nethip Oct 19, 2016
22645c0
Merge pull request #590 from adobe/prashant/fixCompilationError
madanbn Oct 19, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
23 changes: 23 additions & 0 deletions .brackets.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"jslint.options": {
"vars": true,
"plusplus": true,
"node": true,
"browser": false,
"devel": true,
"nomen": true,
"indent": 4,
"maxerr": 50,
"regexp": true,
"es5": true
},
"defaultExtension": "js",
"language": {
"javascript": {
"linting.prefer": ["ESLint", "JSLint"],
"linting.usePreferredOnly": true
}
},
"spaceUnits": 4,
"useTabChar": false
}
2 changes: 2 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Third party modules
**/thirdparty/**
46 changes: 46 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{
"env": {
"node": true
},
"rules": {
"no-bitwise": 2,
"curly": 2,
"eqeqeq": 2,
"guard-for-in": 2,
"wrap-iife": [2, "outside"],
"no-use-before-define": 2,
"new-cap": 2,
"no-caller": 2,
"no-empty": 2,
"no-new": 2,
"no-invalid-regexp": 2,
"no-control-regex": 2,
"no-regex-spaces": 2,
"no-undef": 2,
"strict": 2,
"no-unused-vars": [2, {"vars": "all", "args": "none"}],
"semi": 2,

"no-iterator": 2,
"no-loop-func": 2,
"no-multi-str": 2,
"no-fallthrough": 2,
"no-proto": 2,
"no-script-url": 2,
"no-shadow": 0,
"no-shadow-restricted-names": 2,
"no-new-func": 2,
"no-new-wrappers": 2,
"no-new-require": 2,
"new-parens": 2,
"no-new-object": 2,
"no-invalid-this": 2,
"indent": [2, 4],

"valid-jsdoc": 0,
"valid-typeof": 2,

"no-trailing-spaces": [2, { "skipBlankLines": true }],
"eol-last": 2
}
}
31 changes: 17 additions & 14 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,15 @@ xcodebuild/*
/npm-debug.log
/downloads

appshell.xcodeproj
Brackets.vcxproj
appshell.sln
libcef_dll_wrapper.vcxproj
*.xcodeproj
*.VC.db
*.VC.VC.opendb
.vs/
.vscode/
*.vcxproj
*.vcxproj.filters
*.vcxproj.user
*.sln

*.pbxuser
*.perspective
Expand All @@ -24,18 +29,17 @@ libcef_dll_wrapper.vcxproj
*.sdf
*.opensdf
*.suo
*.vcxproj.filters
*.vcxproj.user
*.log
*.dmg

Debug
Release
Resources
deps
include
/Debug
/Release
/Resources
/deps
/include
ipch
libcef_dll
/libcef_dll
/out
tools

/installer/mac/staging/
Expand All @@ -51,8 +55,7 @@ fr-fr.mst
appshell_extensions_js.o
Makefile
appshell.Makefile
Brackets.target.mk
libcef_dll_wrapper.target.mk
*.target.mk
appshell/gtk
appshell/gtk/*

Expand Down
75 changes: 0 additions & 75 deletions .jshintrc

This file was deleted.

39 changes: 21 additions & 18 deletions Gruntfile.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013 Adobe Systems Incorporated. All rights reserved.
* Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
Expand All @@ -20,13 +20,11 @@
* DEALINGS IN THE SOFTWARE.
*
*/
/*jslint regexp:true*/
/*global module, require, process*/
module.exports = function (grunt) {
"use strict";

"use strict";

module.exports = function (grunt) {
var common = require("./tasks/common")(grunt),
resolve = common.resolve,
platform = common.platform(),
staging;

Expand Down Expand Up @@ -71,7 +69,7 @@ module.exports = function (grunt) {
},
"node-mac": {
"dest" : "<%= downloads %>",
"src" : "http://nodejs.org/dist/v<%= node.version %>/node-v<%= node.version %>-darwin-x86.tar.gz"
"src" : "http://nodejs.org/dist/v<%= node.version %>/node-v<%= node.version %>-darwin-x64.tar.gz"
},
/* win */
"cef-win": {
Expand All @@ -84,8 +82,9 @@ module.exports = function (grunt) {
},
"node-win": {
"dest" : "<%= downloads %>",
"src" : ["http://nodejs.org/dist/v<%= node.version %>/node.exe",
"http://nodejs.org/dist/npm/npm-<%= npm.version %>.zip"]
"src" : process.arch === "x64" ?
"http://nodejs.org/dist/v<%= node.version %>/win-x64/node.exe" :
"http://nodejs.org/dist/v<%= node.version %>/win-x86/node.exe"
}
},
"clean": {
Expand Down Expand Up @@ -160,7 +159,10 @@ module.exports = function (grunt) {
"Brackets",
"Brackets-node",
"cef.pak",
"devtools_resources.pak"
"cef_100_percent.pak",
"cef_200_percent.pak",
"devtools_resources.pak",
"icudtl.dat",
],
"dest" : "<%= build.staging %>"
},
Expand Down Expand Up @@ -204,10 +206,14 @@ module.exports = function (grunt) {
"dest" : "deps/cef"
}
},
"jshint": {
"all" : ["Gruntfile.js", "tasks/**/*.js"],
"eslint": {
"all" : [
"Gruntfile.js",
"tasks/**/*.js",
"appshell/node-core/*.js"
],
"options": {
"jshintrc" : ".jshintrc"
"quiet" : true
}
},
"build": {
Expand All @@ -229,15 +235,12 @@ module.exports = function (grunt) {
"version" : "3.2623.1397"
},
"node": {
"version" : "0.10.24"
},
"npm": {
"version" : "1.2.11"
"version" : "6.3.1"
}
});

grunt.loadTasks("tasks");
grunt.loadNpmTasks("grunt-contrib-jshint");
grunt.loadNpmTasks("grunt-eslint");
grunt.loadNpmTasks("grunt-contrib-copy");
grunt.loadNpmTasks("grunt-contrib-clean");
grunt.loadNpmTasks("grunt-curl");
Expand Down
22 changes: 11 additions & 11 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
Copyright (c) 2012 - present Adobe Systems Incorporated. All rights reserved.

Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"),
to deal in the Software without restriction, including without limitation
the rights to use, copy, modify, merge, publish, distribute, sublicense,
and/or sell copies of the Software, and to permit persons to whom the
copy of this software and associated documentation files (the "Software"),
to deal in the Software without restriction, including without limitation
the rights to use, copy, modify, merge, publish, distribute, sublicense,
and/or sell copies of the Software, and to permit persons to whom the
Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
Loading