-
Notifications
You must be signed in to change notification settings - Fork 604
Update all path buffers to accept long UNC paths #397
Conversation
JeffryBooher
commented
Dec 6, 2013
- FIxes appshell.fs.showOpenDialog: Windows wchar_t buffer is too small brackets#5270
|
@redmunds I noticed that there were merge conflicts w/ my other pull request. So, I took the liberty of updating this branch as well, so that it can be Merged. |
|
Thanks. |
|
@JeffryBooher This change increases the buffer size from 260 to 4096 which allows brackets-shell to handle longer file paths. But the bug report states: "... the buffer should be large enough to accommodate collections of paths. In my particular installation, I needed to support several thousand file selections to deal with image sequences." Does this add support for collections of paths that support "several thousand file selections" as requested in the bug? |
|
I wonder what the use case for selecting a thousand files in the Open dialog is...seems a bit outside our wheelhouse. |
|
@njx I'd like to get feedback from original filer about a usage scenario, but I think this should probably be merged to get the longer file paths. Agreed? |
|
Yup, I definitely think this makes sense to merge--was just thinking that we don't really need to generalize it for the "thousands of paths" case yet until we understand why that's valuable. |
|
Looks good. Merging. |
Update all path buffers to accept long UNC paths
|
@redmunds @njx this change works |
Update all path buffers to accept long UNC paths