Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added channel close listener and interruption of the pipelines in case Aquarium was the cause #26

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

sparshev
Copy link
Collaborator

With this change on any channel close plugin will check if the cause is Aquarium (timeout or any other issue with application state) and will notify pipeline in this case. Otherwise it will just wait because the closed channel could mean that agent temporarily disconnected.

Also the change contains some cleanups and small fixes.

Related Issue

fixes: #18

Motivation and Context

Make it better

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev added the bug Something isn't working label Aug 15, 2024
@sparshev sparshev self-assigned this Aug 15, 2024
@sparshev sparshev merged commit 914a41c into main Aug 15, 2024
5 checks passed
@sparshev sparshev deleted the ANJ-18 branch August 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify executing pipeline on resource termination by timeout
1 participant