Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exception during showing Node settings and set exclusive for mode #22

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

sparshev
Copy link
Collaborator

Now node configuration displays the general node parameters as well as ApplicationUID for reference. Also it makes the node exclusive - there is no reason to keep it available for not specific jobs that needs this specific worker.

Related Issue

fixes: #19

Motivation and Context

Otherwise it shows exception there - not good.

How Has This Been Tested?

Manually

Screenshots (if appropriate):

jenkins_node_settings

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev self-assigned this Aug 14, 2024
@sparshev sparshev added bug Something isn't working enhancement New feature or request labels Aug 14, 2024
@sparshev sparshev merged commit 7473410 into main Aug 14, 2024
5 checks passed
@sparshev sparshev deleted the ANJ-19 branch August 14, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View configuration is not working for aquarium node
1 participant