Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added golangci-lint and multiple fixes for all kind of checks #84

Merged
merged 6 commits into from
Sep 7, 2024

Conversation

sparshev
Copy link
Collaborator

@sparshev sparshev commented Sep 6, 2024

The most important changes in this refactoring:

  • Added golangci to github workflow
  • Bumped version of go to 1.22 to fix for loops vars
  • Removed cluster logic since dead code and better one in lmplement the cluster logic #30
  • Fixed unauthorized access to application resource
  • Fixed not checked user struct type conversion in API
  • Multiple security and style fixes

Related Issue

#82

Motivation and Context

When I saw how many issues is there - there no way around

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The most important:
* Added golangci to github workflow
* Bumped version of go to 1.22 to fix for loops vars
* Removed cluster logic since dead code and better one in #30
* Fixed unauthorized access to application resource
* Fixed not checked user struct type conversion in API
* Multiple security and style fixes
@sparshev sparshev added bug Something isn't working enhancement New feature or request labels Sep 6, 2024
@sparshev sparshev self-assigned this Sep 6, 2024
lib/proxy_ssh/proxy.go Fixed Show fixed Hide fixed
lib/proxyssh/proxy.go Dismissed Show dismissed Hide dismissed
@sparshev sparshev force-pushed the golang_static_checks branch from 7b61abe to 3dc66fd Compare September 7, 2024 05:49
@sparshev sparshev merged commit 4a3c572 into main Sep 7, 2024
7 checks passed
@sparshev sparshev deleted the golang_static_checks branch September 7, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants