Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue with cleanup after fail and a number of bugfixes for AWS #45

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

sparshev
Copy link
Collaborator

@sparshev sparshev commented Mar 7, 2023

Now images and VMX Allocation cleans up if something bad happened during the process. And this change also contains a number of bugfixes for AWS driver.

  • Cleanup is quite an important feature, otherwise automated Fish is clogging the disk or leftovers from the bad allocations. Also it's good to clean if images was not downloaded/unpacked correctly (I'm looking at you, max opened files on mac!)
  • Removing driver from the list if it failed preparation phase - if they are not prepared, so what's the point of having them in the roster...
  • 1 minute retry AWS connection on start in case network is not working - caught on mac after reboot, service starts and gets no internet...
  • Fixed nasty issue with waiting of AWS instance IP and disks - it sometimes don't get the IP immediately and just waits for 5 microseconds and repeats with 0 result of course.

Related Issue

fixes: #6

How Has This Been Tested?

Automatically

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev added the bug Something isn't working label Mar 7, 2023
@sparshev sparshev self-assigned this Mar 7, 2023
@sparshev sparshev merged commit aeb26ff into main Mar 7, 2023
@sparshev sparshev deleted the AF-6 branch March 7, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper cleaning on allocation/deallocation failure
1 participant