Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lifetime for the Resources in Label definition #39

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

sparshev
Copy link
Collaborator

@sparshev sparshev commented Nov 16, 2022

With lifetime timeout we can be sure the application resource will not be executed forever if something bad happened and based on this timeout fish node will be able to do some heuristics on how much time left till provisioning the next resource (#38).

The duration is set in standard golang format as string "1h2m3s", if it's empty or 0 - the default from fish config will be used. And if it's negative (like "-1s") then the resource should exist until user say so by deallocating it.

This change really helps with clouds where we certainly don't need to left the resources for long time.

Related Issue

fixes: #28

How Has This Been Tested?

Automatically

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev added the enhancement New feature or request label Nov 16, 2022
@sparshev sparshev self-assigned this Nov 16, 2022
@sparshev sparshev merged commit be38ee2 into main Nov 16, 2022
@sparshev sparshev deleted the AF-28 branch November 16, 2022 08:11
sparshev added a commit to adobe/aquarium-net-jenkins that referenced this pull request Nov 25, 2022
This change adds basic CI, updates the plugin to latest Fish adobe/aquarium-fish#39, prints allocation and chosen label info to the task log and fixes a couple of issues.

Warning: Incompatible with previous versions of Fish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resource timeout in label definition
1 participant