Skip to content

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 4, 2024

How Has This Been Tested?

  • npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56ee808) 100.00% compared to head (57e2180) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           65        68    +3     
  Branches         9        11    +2     
=========================================
+ Hits            65        68    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron
Copy link
Member Author

shazron commented Jan 4, 2024

The tests are fine locally but since they open ports, we get ECONNREFUSED on the CI servers.
May need to change the hostname to localhost when on CI, or ipv6 loopback [::1]

@shazron shazron merged commit 331b652 into main Jan 8, 2024
@shazron shazron deleted the update-18-20 branch January 8, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants