Repository navigation
Conversation
This is for the situation where if you have a file watcher process, and you need to rebuild an action due to a webpack-config.js change.
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1038 1043 +5
Branches 256 256
=========================================
+ Hits 1038 1043 +5
Continue to review full report at Codecov.
|
purplecabbage
left a comment
There was a problem hiding this comment.
This looks good, but I worry that it leads to a greater maintenance workload for us.
Already, there is an issue where if an error is introduced in the webpack-config, hot reloading breaks, and no info is presented to the user, there are probably more latent issues we would uncover over time, where currently we do not have a responsibility to provide this functionality.
Also, I suspect the primary use cases for modifying webpack config while it is loading would be to add webpack plugins, which in turn need to be installed ... does that mean we also auto-install?
I am okay with merging this, I just want us to be sure we want the extra technical debt that may arise from adding it.
It would also be great if this feature came as a result of an ask from our users, personally I have very little understanding of how important this feature might be.
This is for the situation where if you have a file watcher process, and you need to rebuild an action due to a webpack-config.js change.
Closes #35
How Has This Been Tested?
actions/webpack-config.jsfile, exporting a CommonJS module as a webpack configDEBUG=@adobe/aio-lib-runtime:action-builder:debug aio app runactions/webpack-config.jswith a new entry/delete an entrynpm testTypes of changes
Checklist: