fix: for deploy service int interfaces, and apihost get urls output #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| // we still want to serve dataplane requests on adobeioruntime.net | ||
| return urlJoin( | ||
| 'https://' + config.ow.namespace + '.' + cleanApihost, | ||
| 'https://' + config.ow.namespace + '.' + 'adobeioruntime.net', |
There was a problem hiding this comment.
Just a nit pick, adobeioruntime.net can be moved as a constant in the same file.
There was a problem hiding this comment.
sorry missed it, keeping a note, thanks Sandeep
sandeep-paliwal
approved these changes
Sep 11, 2025
pru55e11
approved these changes
Sep 11, 2025
shazron
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
follow up on #219
intinterfacesgetActionUrls, should returnadobeioruntime.netfor action urls as deploy service is only used on control-plane.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: