Skip to content

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Apr 20, 2023

Description

This makes the lib a little more future-proof, instead of being forced to update our allowed kinds every time the server does, we allow some drift by asking the server directly.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #138 (43e8ee1) into master (42f790e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #138   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1316      1320    +4     
  Branches       348       351    +3     
=========================================
+ Hits          1316      1320    +4     
Impacted Files Coverage Δ
src/utils.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice lgtm

@purplecabbage purplecabbage merged commit 592171f into master Apr 26, 2023
@purplecabbage purplecabbage deleted the FutureProof branch April 26, 2023 17:42
purplecabbage added a commit that referenced this pull request Jan 28, 2025
purplecabbage added a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants