upgrading to java17, cloudevents latest version #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| return ZonedDateTime.parse(jsonParser.getText(), DateTimeFormatter.ISO_OFFSET_DATE_TIME); | ||
| } catch (DateTimeException e) { | ||
| throw new IllegalArgumentException("could not parse"); |
Member
There was a problem hiding this comment.
Please include the stacktrace
Suggested change
| throw new IllegalArgumentException("could not parse"); | |
| throw new IllegalArgumentException("Could not parse", e); |
Collaborator
Author
There was a problem hiding this comment.
done. please approve
abhupadh
had a problem deploying
to
aio_stage_oauth
GitHub Actions
Failure
abhupadh
had a problem deploying
to
aio_stage_oauth
GitHub Actions
Failure
abhupadh
temporarily deployed
to
aio_stage_oauth
GitHub Actions
Inactive
Collaborator
Author
|
@francoisledroff please approve |
shikhartanwar
approved these changes
Mar 18, 2025
francoisledroff
requested changes
Mar 20, 2025
Collaborator
There was a problem hiding this comment.
Not sure we want this...
- we had customers requesting support for aem6.4 and java 8
- we still have the
maven-compiler-plugintargetting ava 8 - see #130
- we still have the
- we surely have aem6.5 customers in a need for java 11
- and all the GH action build and release are using java 11
- The only cloudevents sdk classes we use are
io.cloudevents.json.ZonedDateTime* - introduced here #126 (I guess we should not have done this that way as ISO Date formatting is coming for free in Jackson using
@JsonFormat - we still have this #16 pending
- but for now I would rather see this PR merged #231 to get rid of this unwanted cloudEvent sdk dependency
Collaborator
Author
|
Keeping this PR open when for when we decide to upgrade this sdk to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrading to java17, cloudevents latest version
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: