Skip to content

Conversation

florind-ens
Copy link
Contributor

@florind-ens florind-ens commented Aug 26, 2021

Description

Replaced deprecated request-promise-native with @adobe/aio-lib-core-networking for improved e2e tests which supports retry.

Related Issue

Fixes #77
Fixes #22

Motivation and Context

We run the e2e tests daily via the aio-e2e-tests repo. The connection to IMS sometimes fails because we can't exchange a jwt token, and we should be using aio-lib-core-networking to do a retry with fallback.

How Has This Been Tested?

By running e2e and unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…o-lib-core-networking for improved e2e tests which supports retry.
@Himavanth Himavanth requested a review from shazron August 27, 2021 06:15
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #81 (63c12a2) into master (8cef01d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          413       420    +7     
  Branches        50        51    +1     
=========================================
+ Hits           413       420    +7     
Impacted Files Coverage Δ
src/ims.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cef01d...63c12a2. Read the comment docs.

Copy link

@Himavanth Himavanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Otherwise LGTM. @shazron ?

Copy link

@Himavanth Himavanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @shazron ?

@florind-ens florind-ens self-assigned this Sep 7, 2021
@florind-ens florind-ens changed the title [ACNA-1228] improve e2e tests with retry and exponential fallback [ACNA-1228][ACNA-1327] improve e2e tests with retry and exponential fallback Sep 7, 2021
@shazron shazron merged commit 7a0c9ac into adobe:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve e2e tests with retry and exponential fallback use node fetch instead of request promise

3 participants