-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add proxy support #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 5 +4
Lines 35 112 +77
Branches 7 20 +13
=========================================
+ Hits 35 112 +77
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! nice work 🙂
To facilitate e2e tests in our libraries, we need to extract the test servers so they can be re-used. Two more things need to be done:
|
Latest changes lgtm |
coverage pending
…-networking into proxy-support
Both these items are complete. The test servers are internal right now and are in the process of going open source. Once they are open sourced and published, this PR needs to be modified to use it. |
Fixes #13
The module export has changed, thus this is a breaking change and will be a major version bump.
Dependents:
How Has This Been Tested?
Dependents
PRs aboveTypes of changes
Checklist: