Skip to content

Conversation

shazron
Copy link
Member

@shazron shazron commented Aug 12, 2021

Fixes #13
The module export has changed, thus this is a breaking change and will be a major version bump.

Dependents:

How Has This Been Tested?

  1. unit tests
  2. server test harness in unit tests (for testing proxy)
  3. manual testing via Dependents PRs above

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron changed the title WIP feat: add proxy and ntlm/kerberos support WIP feat: add proxy support Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #14 (ba92efa) into master (ce565ee) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         5    +4     
  Lines           35       112   +77     
  Branches         7        20   +13     
=========================================
+ Hits            35       112   +77     
Impacted Files Coverage Δ
src/HttpExponentialBackoff.js 100.00% <100.00%> (ø)
src/ProxyFetch.js 100.00% <100.00%> (ø)
src/SDKErrors.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce565ee...ba92efa. Read the comment docs.

@shazron shazron marked this pull request as ready for review August 30, 2021 17:40
@shazron shazron changed the title WIP feat: add proxy support feat: add proxy support Aug 31, 2021
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice work 🙂

@shazron
Copy link
Member Author

shazron commented Sep 7, 2021

To facilitate e2e tests in our libraries, we need to extract the test servers so they can be re-used.

Two more things need to be done:

  1. Extract the test servers and their tests into their own module
  2. We need to create a https-proxy server component to test SSL connections. Currently this is done manually using https://mitmproxy.org/ but we can't automate this, thus we need to create our own (preferably using existing npm modules). A candidate is https://www.npmjs.com/package/http-mitm-proxy

@moritzraho
Copy link
Member

fix: add proxy support for exponentialBackoff

Latest changes lgtm

@shazron
Copy link
Member Author

shazron commented Sep 20, 2021

To facilitate e2e tests in our libraries, we need to extract the test servers so they can be re-used.

Two more things need to be done:

  1. Extract the test servers and their tests into their own module
  2. We need to create a https-proxy server component to test SSL connections. Currently this is done manually using https://mitmproxy.org/ but we can't automate this, thus we need to create our own (preferably using existing npm modules). A candidate is https://www.npmjs.com/package/http-mitm-proxy

Both these items are complete. The test servers are internal right now and are in the process of going open source. Once they are open sourced and published, this PR needs to be modified to use it.

@shazron shazron merged commit fa64e16 into master Sep 29, 2021
@shazron shazron deleted the proxy-support branch September 29, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add our own http client (with proxy support) and our own http.agent proxy
2 participants