Skip to content

ACNA-1833 | Externalising GitHub workflows#79

Merged
amulyakashyap09 merged 6 commits intomasterfrom
feature/externalising-github-workflows
Feb 12, 2024
Merged

ACNA-1833 | Externalising GitHub workflows#79
amulyakashyap09 merged 6 commits intomasterfrom
feature/externalising-github-workflows

Conversation

@amulyakashyap09
Copy link
Copy Markdown
Contributor

Description

Implement reusable github workflows

Related Issue

ACNA-1833

Motivation and Context

  • Code Reusability
  • Avoiding Redundancy

How Has This Been Tested?

  • This will be tested after PR is merged and deployed.
  • This is workflow changes can only be tested post merge.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7def537) 100.00% compared to head (23853dd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          540       540           
  Branches        90        90           
=========================================
  Hits           540       540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amulyakashyap09 amulyakashyap09 changed the title Feature/externalising GitHub workflows ACNA-1833 | Externalising GitHub workflows Dec 18, 2023
@moritzraho
Copy link
Copy Markdown
Member

Pending test results?

Copy link
Copy Markdown
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required checks has changed because of the reuseable workflows - I changed them in the Settings so now all pass

@amulyakashyap09 amulyakashyap09 merged commit 75cc799 into master Feb 12, 2024
@amulyakashyap09 amulyakashyap09 deleted the feature/externalising-github-workflows branch February 12, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants