Skip to content

fix: ACNA-2523 - change subscribeToServicesWithCredentialType to use existing (OAuth S2S OR JWT), if either does not exist, then create#74

Merged
shazron merged 1 commit intomasterfrom
story/ACNA-2523
Sep 6, 2023
Merged

fix: ACNA-2523 - change subscribeToServicesWithCredentialType to use existing (OAuth S2S OR JWT), if either does not exist, then create#74
shazron merged 1 commit intomasterfrom
story/ACNA-2523

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Sep 5, 2023

closes #73

How Has This Been Tested?

  • npm test
  • manual test
    • aio app init --standalone app my-app (Create a new app)
    • aio app add service (add an action, say User Management API)
    • aio app add service --use-jwt (add an action, say Analytics)
    • check that the project does not have any duplicate enterprise credentials (no JWT) in Developer Console

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…uth S2S OR JWT), if either does not exist, then create
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2023

Codecov Report

Merging #74 (76472d9) into master (aaf8835) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          543       540    -3     
  Branches        92        90    -2     
=========================================
- Hits           543       540    -3     
Files Changed Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good timing on the change from @mariam21arauj

@shazron shazron merged commit cfc8d47 into master Sep 6, 2023
@shazron shazron deleted the story/ACNA-2523 branch September 6, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect logic when creating enterprise credentials

3 participants